ChrisASearles / CompLinks

0 stars 0 forks source link

Adding Physical Address fields to " Account Information" section in Account/MyProfile #172

Closed robgpeak closed 7 years ago

robgpeak commented 7 years ago

I would like to add the following fields under First and Last names fields

Address City, State (in a dropdown) Zip

As for the layout of it, I would tighten it up a bit, meaning make a little less space between the rows of fields. Maybe 1/2 the amount of space there is now.

Dwells7583 commented 7 years ago

@cgladue can you add these to the account controller?

cgladue commented 7 years ago

@Dwells7583 tonight sure, its not just the controller the DB needs the fields as well as does all of the DAL, you dont need to be blocked just use dummy data for now and ill wire in the proper data once its available.

Dwells7583 commented 7 years ago

@cgladue when will this be updated?

cgladue commented 7 years ago

@Dwells7583 done, and added to the view as well, you can tidy it up

cgladue commented 7 years ago

@robgpeak i added both address1 and address2 fields, do you want a place to put Apartment Suite etc info or only Street address ?

Dwells7583 commented 7 years ago

@cgladue I only see it added to the view. Are all your files included in your latest commit?

cgladue commented 7 years ago

@Dwells7583 yes, it was added to the ApplicationUser Class as well as the Database and is updating correctly.

robgpeak commented 7 years ago

Here is what I am seeing, and it is fine. Next issue:)

screen shot 2017-06-07 at 4 08 39 pm
cgladue commented 7 years ago

@robgpeak @Dwells7583 Derek will need to make the State dropdown contain all states and also if any one of the address fields are filled in then all should be mandatory, if none are filled in the optional.

robgpeak commented 7 years ago

Agreed.

cgladue commented 7 years ago

@robgpeak and you are ok with all address information being contained within only one line of text correct ?

Dwells7583 commented 7 years ago

@cgladue I am def not getting something on my end. The only thing that was added in that commit was the updated view.

cgladue commented 7 years ago

dont know what to say, it shows nothing on my working folder to commit.

see if yours looks the same image

cgladue commented 7 years ago

@Dwells7583 i am re-comitting the files again see if it works now.

Dwells7583 commented 7 years ago

Ok, I got all the files now. thanks.

Dwells7583 commented 7 years ago

@cgladue OK. The Phone number is not formatted like it was, a few commits ago. Did this change for some reason? It is also not displaying anymore. was the script removed to force the formatted phone number on purpose?

cgladue commented 7 years ago

maskedinput.js was removed because it uses jQuery and Chris said jQuery absolutely cannot be loaded at the same time as angular, so you'll just have to do it in angular i guess. as for the phone not displaying ill look, when i added the additional fields i may have changed the property name give me a few minutes

Dwells7583 commented 7 years ago

OK, that is what I thought. Just confirming. thanks.

Dwells7583 commented 7 years ago

Ok the name was changed to phonenumber from mobile. Its working now. As far as the dropdown for state and the formatting of the phone number, we will circle back to those as there are more pressing items to be addressed first.

cgladue commented 7 years ago

@Dwells7583 i will be adding timezone as a dropdown as well so that will need to be adjusted to look pretty on my next commit

cgladue commented 7 years ago

@Dwells7583 timezone is not going in for go live, it will be done later, so ignore my previous comment.

robgpeak commented 7 years ago

This looks OK, except for the lack of a dropdown for the state field. Having said that, we are going to need to (for now), hide all these fields from the end user's view.

We got feedback from Dover Downs, and they are weary of their user's information being outside of their own personal database. To that end, I am going to start a new thread to make the data that we ask for from end users to be less, and make it more like the social casinos do. @cgladue I would like to have a verbal conversation on this with you and Frank. I will send that request via email.