search

ChrisASearles / CompLinks

0 stars 0 forks source link

Inconsistency in ad model objects #185

Closed ChrisASearles closed 7 years ago

ChrisASearles commented 7 years ago

Ads are being presented using the FeaturedLink class on the category detail page and the Link class on the store detail page. The category page is currently functional, the code for ads on the store page is commented out. If you decide to use the Link class, the MedSqAd display template needs to be updated to use that as the model object instead of the FeaturedLink class. Please also uncomment the code that's loading the ads on the store detail page once this is fixed.

cgladue commented 7 years ago

@ChrisASearles @robgpeak this isnt an inconsistency, one is featured ads and one is just plain ads... the featured ad is on the category page, and is only Ads that have specifically marked as featured. On the store page the ads are all ads for that advertiser.

cgladue commented 7 years ago

closing as a non-issue.

ChrisASearles commented 7 years ago

@cgladue as far as the front-end is concerned, there's no distinction, an ad is an ad, we need the same model object for ads.

cgladue commented 7 years ago

you may have to just deal with it and create a second partial to display it, but ill look into why i split it out.

cgladue commented 7 years ago

Removed all references to FeaturedLink.