search

ChrisASearles / CompLinks

0 stars 0 forks source link

Adjusting the functionality of the sign up page #242

Open robgpeak opened 6 years ago

robgpeak commented 6 years ago

When I attempt to sign up for a new account on the new sign up page with the first and last name, if I enter an email address that is already in the system, but I purposfully (for the sake of testing), enter two different passwords into the password fields, I do NOT receive the message my passwords don't match.

Having said that, I think the first thing it should do is check to see if that email address is already in the system. If it is, then display the message about signing in, or recovering the password. If it is not already in the system, it should check to see if the passwords entered match. If not, I should receive a message saying so. Currently I do not.

The next thing on the same subject is the whole experience should take place in the "overlay screen" so the whole thing is visible on a mobile device. As it is now, I have to scroll down to see the actual join now button, (which is fine), but even still, I cannot scroll up to the top to see the message that says "This email address is already registered, please use the 'Sign In' page to access your account, or reset your password if you forgot it."

I know it's there, I just can't scroll up to see it.

cgladue commented 6 years ago

@Dwells7583 @ChrisASearles

this would be something you guys need to handle, validate the passwords before the form is actually posted to the server, same for the overlay screens @robgpeak wants.

ChrisASearles commented 6 years ago

@cgladue we can do it on the client-side as well but it should absolutely be validated on the server as well the same way the rest of the form is being validated server-side

cgladue commented 6 years ago

server dosnt get password and confirmed password, it only gets password so its not validated on server side since only 1 password value is sent to the server.

Chad Gladue DevNull Technology, LLC

On Sun, Jul 16, 2017 at 8:45 PM, Chris Searles notifications@github.com wrote:

@cgladue https://github.com/cgladue we can do it on the client-side as well but it should absolutely be validated on the server as well the same way the rest of the form is being validated server-side

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ChrisASearles/CompLinks/issues/242#issuecomment-315650073, or mute the thread https://github.com/notifications/unsubscribe-auth/AHjClTFVQefw75sGw00MfcUp-J5X9yjBks5sOq6ygaJpZM4OV4w- .