search

ChrisBuchholz / accord

Data validation library for Rust
MIT License
78 stars 4 forks source link

Codecov integration #5

Open ChrisBuchholz opened 7 years ago

ChrisBuchholz commented 7 years ago

Codecov integration has been added and reports 100% coverage. That cannot be right and should be investigated and fixed so as to report a realistic coverage.

ChrisBuchholz commented 7 years ago

Note that rust code coverage reports done with kcov (which is what codecov integration uses) seemingly doesn't support rustdoc tests.

orhanbalci commented 7 years ago

Hi @ChrisBuchholz kcov does not take into account the functions without test cases. It just reports the ones that are partially or fully tested. Basically if you do not have any test cases your coverage is %100. Makes no sense but this is the case

ChrisBuchholz commented 7 years ago

@orhanbalci: ah, thank for the explanation!