ChrisCScott / forecaster

A personal finances forecasting tool for Canadian retirement planning
Other
1 stars 2 forks source link

Implement tests for contribution groups #38

Closed ChrisCScott closed 6 years ago

ChrisCScott commented 6 years ago

Both RegisteredAccount and Person use contribution_group functionality. Implement tests for at least one of them (presumably RegisteredAccount).

Consider refactoring these classes to encapsulate all of this logic with RegisteredAccount, e.g. by assigning the relevant attributes of Person via a RegisteredAccount method (classmethod?) rather than via a native Person method.