ChrisCScott / forecaster

A personal finances forecasting tool for Canadian retirement planning
Other
1 stars 2 forks source link

Remove transactions input to Account #39

Closed ChrisCScott closed 6 years ago

ChrisCScott commented 6 years ago

There's no need to provide a transactions input arg in Account.__init__. Transaction-adding functionality is managed in every case by the add_transaction method. Removing this argument will remove the most complex part of the __init__ signature.

This is by necessity in the case of any year after the initial year. It's a matter of practicality in the case of the initial year, since we don't generally expect to know what the transactions in an account will be at init time.

ChrisCScott commented 6 years ago

Closed by https://github.com/ChrisCScott/forecaster/commit/6c66cc8ea6a1e5258951da8a4e732e766a5e48f3