search

ChrisCates / CommonCrawler

🕸 A simple way to extract data from Common Crawl
MIT License
33 stars 12 forks source link

#10 Docker Container #11

Closed iamonuwa closed 5 years ago

iamonuwa commented 5 years ago

Fixes #10

iamonuwa commented 5 years ago

@ChrisCates please take a look

ChrisCates commented 5 years ago

@iamonuwa, this looks excellent and well done. Would it be possible to test it as a Dockerfile instead in Travis?

Once that change is made I will make sure to have the money released to your account after I test it myself and approve the changes.

iamonuwa commented 5 years ago

Would it be possible to test it as a Dockerfile instead in Travis?

Hi can you explain what you mean by test as Dockerfile and not travis please?

ChrisCates commented 5 years ago

@iamonuwa, in the Travis builds. The program should be able to run in Linux, Unix, and Windows as a Docker Container.

This link may prove useful: https://docs.travis-ci.com/user/docker/ If you need further clarification. Let me know!

iamonuwa commented 5 years ago

@ChrisCates ATM, docker for macos is not supported. Will it be okay to work with windows and linux?

ChrisCates commented 5 years ago

@iamonuwa, yes, it's okay. As long as I am able to run it on my own Mac OS computer.

Thank you for catching that. Appreciated.

iamonuwa commented 5 years ago

Sweet! Making changes now

iamonuwa commented 5 years ago

@ChrisCates please take a look

ChrisCates commented 5 years ago

@iamonuwa, almost at the finish line: https://travis-ci.org/ChrisCates/CommonCrawler/jobs/528564834

Also, the Travis-CI config should be able to run it as go run src/*.go and pass, I've left it up to you to decide how that should be executed as a Docker container. I've updated the repository to ensure that you can compile it with the specified command I provided, so please pull from the master branch if you have any questions we can discuss further.

Once that's sorted out. Will close and pay you the bounty. Keep up the great work, will have more coming next week.

Review #1 and #5 and let me know if you are interested in those tasks.

iamonuwa commented 5 years ago

@iamonuwa, almost at the finish line: https://travis-ci.org/ChrisCates/CommonCrawler/jobs/528564834

Also, the Travis-CI config should be able to run it as go run src/*.go and pass, I've left it up to you to decide how that should be executed as a Docker container. I've updated the repository to ensure that you can compile it with the specified command I provided, so please pull from the master branch if you have any questions we can discuss further.

Once that's sorted out. Will close and pay you the bounty. Keep up the great work, will have more coming next week.

Review #1 and #5 and let me know if you are interested in those tasks.

For the failure, its because docker is currently not supported on macos.

Do you need me to allow it to run through go run src/*.go if its OSX?

I'll go through the issues.

iamonuwa commented 5 years ago

@ChrisCates I'll start with #5 now.

ChrisCates commented 5 years ago

The CI test you provided for OSX was great and what I wanted. Keep it up, we will discuss #1, #5, #13 Friday.