Memberships linked with recurring payments are not updated by eWay recurring

[eileenmcnaughton]

The function to confirm the pending contribution does not update related entities (memberships). I have added a fix to my PR that calls the api completetransaction directly. This api transitions the membership and in addition it sends out emails (depending on configuration).

The API was introduced in 4.3.4 so not sure whether that is an issue. We are now entirely using 4.4.7

[eileenmcnaughton]

Note that the fix I put in that PR works for pending but not ongoing transactions :-( I will work on that

[kenwest]

My thought (partially expressed on #17) was to process pending and scheduled contributions in a symmetric way. Specifically, get_pending_recurring_contributions() and get_scheduled_contributions() would each return an array like ...

array (
    array (
        'type' => 'Pending',
        'contribution' => Object,
        'contribution_recur' => Object
    ),
    ...
)

... where 'type' is either 'Pending' or 'Scheduled' and allows the code to handle differences between the 2 cases.

[eileenmcnaughton]

OK - so that's at the point of retrieval - rather than the point of 'what to do with them'? It seems the 'what to do with them' only changes once they are processed via eway & even then only because CiviCRM doesn't have a good built in way of dealing with recurrences (ie. updating related memberships)

[eileenmcnaughton]

NB - might be better if you try to merge my changes into what you are working on before you go to far or you will never make hide nor hair of them :-)

[eileenmcnaughton]

I think this can be closed - of course the moving targetness of civi-core makes all of these a challenge