search

ChrisChinchilla / CiviCRM-eWay-recurring-payment-processor

CiviCRM eWay recurring payment processor
https://github.com/henare/CiviCRM-eWay-recurring-payment-processor#readme
0 stars 4 forks source link

alternate fix to subscription checksum, use sendconfirmation function #19

Closed eileenmcnaughton closed 9 years ago

kenwest commented 9 years ago

I like the idea of doing it this way.

eileenmcnaughton commented 9 years ago

note I've fixed that fix up a bit more(new commit)

ChrisChinchilla commented 9 years ago

This pull request has to be merged manually, as I haven't had much to do with it, are you happy to do that?

kenwest commented 9 years ago

Eileen,

There's an issue with the cancel and update links in the confirmation email. The URL they point to is https://www.eway.com.au/gateway/ManagedPaymentService/test/managedcreditcardpayment.asmx?WSDL which is the 'url_site_test_default' set in Ewayrecurring.mgd.php. (This is a test contribution, hence the use of the test link.)

The links should point to the URLS for CRM_Contribute_Form_CancelSubscription (/civicrm/contribute/unsubscribe) and CRM_Contribute_Form_UpdateSubscription (/civicrm/contribute/updaterecur)

eileenmcnaughton commented 9 years ago

Ken - you mean as a result of the PR Chris merged last night there is a regression?

kenwest commented 9 years ago

Eileen - I'm referring to this commit

eileenmcnaughton commented 9 years ago

yes - but I mean - this is a new regression?

kenwest commented 9 years ago

Yes. In my fork of this repo, my 'master' commit works OK, but my 'failed-payment' commit fails as above. The 'failed-payment' commit is identical to to your fork's master commit 497cb45

(BTW I'm trying to keep in step with you but add failed payment processing. As a git noobie that could be interesting ;-)

eileenmcnaughton commented 9 years ago

thanks - I'll take a look. I'll get stuff merge in too

kenwest commented 9 years ago

Eileen, I've refactored the code for processing pending and scheduled contributions, so they both use the code that was in your function _civicrm_api3_job_eway_process_pending_contributions() which I've renamed _civicrm_api3_job_eway_process_contribution()

See the commits 00cf5a3 and aea8bc6 on my fork. I've tested this change on 4.5 and it looks good. Would you like me to PR that against your fork?

kenwest commented 9 years ago

Eileen, I've fixed the problem with subscriptionURL(). See commit edd8f94 on my fork.

eileenmcnaughton commented 9 years ago

closing this - should all be covered when we merge in my branch that Ken & I have been working on