ChrisChinchilla / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=ChrisChinchilla.vale-vscode
MIT License
34 stars 5 forks source link

Massive CPU usage when used with VS Code #722 #13

Closed theletterf closed 7 months ago

theletterf commented 8 months ago

Check for existing issues

Environment

macOS 13.6 VSCode 1.83.1 Vale VSCode extension 0.17.5 Vale 2.29.6

Describe the bug / provide steps to reproduce it

When doing search & replace operations in VS Code, the editor (or the add-on, I'm not sure) seems to spawn several vale processes, which end up consuming all available CPU cycles. See screenshot after performing a dozen search & replaces in an rST repository (without opening the files):

I had to close all the vale processes from the Activity Monitor, after which everything got back to normal. This doesn't seem to happen when editing single files. I wonder if this is an add-on issue, a VS Code issue, or a Vale bug.

ChrisChinchilla commented 7 months ago

@theletterf I can reproduce this, but I get nowhere near the kind of CPU activity you experience, and they all quit when done. Still, they shouldn't really trigger at all, I guess.

Can I get a couple more details in case it's relevant…

ChrisChinchilla commented 7 months ago

Scrap that, I've figured out what's doing this.

ChrisChinchilla commented 7 months ago

OK @theletterf and @Makki93 There should now be a pre-release version available in the VSCode extension. You might need to uninstall the current version to see it, and then you can select the pre-release from the install dropdown. That part of the VSCode interface is a little new to me. You can switch between versions too. Try that version and let me know if it solves these issues.

theletterf commented 7 months ago

There's an option that says "Switch to pre-release" (so convenient!). Just did the change, will let you know. So far, it seems snappier!

ChrisChinchilla commented 7 months ago

@theletterf and @Makki93 It looks like this is working out I think?

theletterf commented 7 months ago

It is!