ChrisChinchilla / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=ChrisChinchilla.vale-vscode
MIT License
34 stars 5 forks source link

Extenion isn't working with newest version of Vale, 3.3.0 #30

Closed maxhoriba closed 3 months ago

maxhoriba commented 3 months ago

Current local version of Vale is 2.28.2.

Today, I tried upgrading my local version of Vale to 3.3.0, and the extension stopped working.

Current version of extension I'm using: image

ChrisChinchilla commented 3 months ago

@maxhoriba Hmm, everyone else with the latest versions now has this working. Can you try quitting VScode and reopening it? Just to be sure?

maxhoriba commented 3 months ago

@maxhoriba Hmm, everyone else with the latest versions now has this working. Can you try quitting VScode and reopening it? Just to be sure?

Definitely isn't working. I tried upgrading, disabling the extension, closing VS Code, then opening again, which didn't work. Downgraded back to 2.28.2 and it works again.

ChrisChinchilla commented 3 months ago

@maxhoriba No one else seems to be having this issue. So could you give me some extra details…

maxhoriba commented 3 months ago

Hi Chris, here's what I have:

1) I have some warnings, but I think they're unrelated to vale. 2) Windows 10. 3) I get an error:

E100 [vocab] 
Runtime error 'config\vocabularies/my-own-rules' directory does not exist
Execution stopped with code 1.

4) Here are my settings: image

ChrisChinchilla commented 3 months ago

@maxhoriba

Runtime error 'config\vocabularies/my-own-rules' directory does not exist

Definately looks concerning to me! Does Vale work if you run from command line in the same directory?

maxhoriba commented 3 months ago

@maxhoriba

Runtime error 'config\vocabularies/my-own-rules' directory does not exist

Definately looks concerning to me! Does Vale work if you run from command line in the same directory?

It doesn't! I tried and I get the same error when I run a command, for example: vale my-topic.md. Vale still works for 2.28.2...

maxhoriba commented 3 months ago

Fixed the issue locally. Closing this now