search

ChrisChinchilla / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=ChrisChinchilla.vale-vscode
MIT License
34 stars 5 forks source link

Point to vale binary outside, but relative to workspace #33

Closed hangie closed 2 months ago

hangie commented 3 months ago

The binary path doesn't allow paths outside of the workspace. We typically have venv a level up as we use multi folder workspaces. I want to point there for vale, but currently that is blocked.

hangie commented 3 months ago

The bug is caused in this: https://github.com/ChrisChinchilla/vale-vscode/blob/b1819ae01c1af0feb6ffaf2e309366c7785fef34/src/features/vsUtils.ts#L10-L24

This line: https://github.com/ChrisChinchilla/vale-vscode/blob/b1819ae01c1af0feb6ffaf2e309366c7785fef34/src/features/vsUtils.ts#L15

should be run on the result of this line: https://github.com/ChrisChinchilla/vale-vscode/blob/b1819ae01c1af0feb6ffaf2e309366c7785fef34/src/features/vsUtils.ts#L18

hangie commented 2 months ago

Released in v0.19.0