search

ChrisChinchilla / vale-vscode

A Visual Studio Code extension for the Vale CLI.
https://marketplace.visualstudio.com/items?itemName=ChrisChinchilla.vale-vscode
MIT License
34 stars 5 forks source link

Support for Edit #45

Open alexvonme opened 1 week ago

alexvonme commented 1 week ago

Does the extension support the action to edit from Vale?

I've tried the example given by the lead developer of Vale, but it doesn't trigger the appropriate fix. The Quick Fix option just gives out the No suggestion found message.

I thought this might be a problem with the extension because the screenshot from the developer (which I presume is from Sublime Test) seems to suggest the correct answer yet I haven't been able to get the same Quick Fix option in VSCode. I also tried the other parameters from edit such as trim_right and realized I can't get the correct Quick Fix options for them either. Only No suggestion found.

The extension supports the replace and suggest actions, so I was hoping that it could also support, the admittedly more complicated, edit.

jdkato commented 1 week ago

This will be possible once #23 is complete.

ChrisChinchilla commented 1 week ago

Yes @alexvonme What @jdkato says is mostly true, I think the extension supported (or supports) some edit actions, but it depends on the style rule as the extension then has to add support for every potential option. So I paused development of those in favour of attempting to work on #23 instead, but that’s taking some time due to all sorts of complications (and work 😅). Getting back to it very soon though.

ccoVeille commented 1 week ago

Thanks for the update @ChrisChinchilla , and thanks for working on LSP, it will help solving issues and will be easier to maintain 🥰

alexvonme commented 1 week ago

@ChrisChinchilla thank you for the detailed answer. I asked in part to confirm that it wasn't an issue specific to my configuration. We'll follow that issue as well.

ChrisChinchilla commented 1 week ago

@ccoVeille and @alexvonme By the way, the pre-release version of the extension available in VSCode does use the LSP, but it doesn't do too much else 😅