ChrisDuffley / stationPlaylist

StationPlaylist Studio add-on for NVDA screen reader
GNU General Public License v2.0
8 stars 5 forks source link

SPL Engine and Streamer: traceback when exiting NVDA while focused on Streamer without moving focus to encoders firstHi, #132

Closed josephsl closed 4 years ago

josephsl commented 4 years ago

Hi,

Discovered while debugging #131

Suppose a user opens Streamer or SPL Engine (encoder management from Studio). Without moving focus to encoder list, user exits NVDA.

Expected: no errors and sounds. Actual: a traceback involving dictionary assignment to None. Cause: incomplete encoder cleanup - it doens't check if stream labels were not initialized. Solution: strengthen encoder settings cleanup by returning early if encoder settings is None.

Thanks.

josephsl commented 4 years ago

Destined for 20.05.