search

ChrisDuffley / stationPlaylist

StationPlaylist Studio add-on for NVDA screen reader
GNU General Public License v2.0
8 stars 5 forks source link

Cart Explorer: move cart gesture assignments to splmisc module #146

Closed josephsl closed 4 years ago

josephsl commented 4 years ago

Hi,

To be done after 20.09-LTS is declared (only for stable branch):

Currently Cart Explorer helper such as cart gestures builder is split between Studio app module main file and splmisc module. For consistency and to let people introduce new featurs, move majority of Cart Explorer helper to splmisc module. The immediate benefits are:

  1. Define a private tuple of cart machine commands.
  2. Use either list addition or itertools.chain to map cart keys to jingles.
  3. Perhaps Cart Explorer and friends could be split into a separate module.

Because of massive changes involved, this will be done as part of stable branch after 20.09 is done.

Thanks.

josephsl commented 4 years ago

Hi,

Too drastic, so closing in favor of #147.

Thanks.