ChrisDuffley / stationPlaylist

StationPlaylist Studio add-on for NVDA screen reader
GNU General Public License v2.0
8 stars 5 forks source link

Track comments: key error when trying to delte a nonexistent comment #156

Closed josephsl closed 3 years ago

josephsl commented 3 years ago

Hi,

Found while investigating several issues related to the user interface flagged by Mypy:

Suppose a user opens track comments dialog for a track (Alt+NVDA+C three times). With the track comment field empty, user clicks OK buton.

Expected: no errors. Actual: KeyError. Cause: incomplete logic - NVDA does not check if a track file exists inside track comments database if track comments value is an empty string. Implications: although not directly related, it would be preferable to pass on (do nothing) if track comments dialog remains open after Studio window is gone. Also, this bug affects 20.09.x.

Thanks.