nickai
commented
8 years ago :+1: Thanks for submitting Chris. I'd encourage you to circle back and clean up the design. There are a lot of learnings during this process. A few notes after checking out the code:
- Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you can take a quick look here.
- You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
- In a future homework, we will cover how to implement models that can deserialize from an NSDictionary. It might be interesting to check out the Mantle project for a lightweight ORM.
- A good design is to have your custom Movie cell have a property
movie. In the custom setter ofmovie, you can configure the various labels and images. This decouples your custom cells from the table view controllers. - Nice work loading the images asynchronously.
- Note that your images look stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
- Nice work implementing the error message on network failure. Be careful to re-hide the error message if the user pulls to refresh and the next request succeeds.
In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.
One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.
We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.
If you have any particular questions about the assignment or the feedback, feel free to reply here or email us at support@codepath.com.
I've completed the required user stories. I've got a busy weekend ahead of me so I'll try to find time to do the optional stories and clean up the design but I wanted to make sure I submitted this ahead of time.
/cc @codepathreview