search

ChrisGuzman / tipCalculator

Proof of concept tip calculator made for codepath prework
1 stars 1 forks source link

Codepath review #1

Open ChrisGuzman opened 9 years ago

ChrisGuzman commented 9 years ago

Hey /cc @codepathreview! Check out my app please :)

ChrisGuzman commented 9 years ago

I just made these additions:

nickai commented 9 years ago

Excellent work Chris! I really like that you extended your app to include smiley faces above the tip amounts and a tableView in the settings screen. TableViews are one of the most powerful views that exist in iOS and we'll be covering it in depth as one of the first topics in the class.

This pre-work was intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer learn all practical iOS development and best practices as quickly as possible. We also do a code review for each submitted project. Nice job with the project, hope you found it as a helpful introduction.

We are reviewing the submissions right now and will get in touch with you via email a few days after the submission closing date, October 9th, 2015. In the mean time, feel free to continue working on any extensions to your tip calculator app and just add a comment to this issue if you decide to do so.

ChrisGuzman commented 9 years ago

Thanks for the feedback @nickai!

I just made the following change: Use locale-specific currency and currency thousands separators

/cc @codepathreview

ChrisGuzman commented 9 years ago

I also just added the following features:

ChrisGuzman commented 9 years ago

I also just made some styling and color additions.

nickai commented 9 years ago

Your app looks great! Thanks for letting me know about your latest additions.