search

ChrisH667 / pwp-capstones

0 stars 1 forks source link

Executive Summary #8

Open gabriel1200 opened 5 years ago

gabriel1200 commented 5 years ago

Altogether a fantastic job! There were two logical issues in get_average_sentence_length and percent_difference, and the issues themselves can be resolved in about a minute :) . Your logic for the more difficult function definitions was well considered.

I'd also encourage you to comment more of your code in the future. While you did a great job leaving test cases for me, getting in the habit explaining your function logic(even if only a few words) is essential when working on large collaborative projects.

In the future I would consider being a bit more descriptive in your variable names, and adding those comments ;) . But you should be really proud of your work on this assignment 👍

4/4, Exceeds Expectations :).

ChrisH667 commented 5 years ago

Your feedback is much appreciated, Gabriel. I struggled quite a bit with Class concepts, so I was expecting a dumpster fire of a review. :) I've fixed the two errors, and now have the below result, hopefully correct this time. I uploaded a new file, Murder+Mystery+FIXED.ipynb. Lily: 0.3202063002470752 Myrtle: 0.08022675114938956 Gregg: 0.2297903530195564

gabriel1200 commented 5 years ago

You got it :) . Gregg is a bit off, but that's not due to your functions(I tested it myself, I think the string you copied for gregg differs from codecademy's. When I replaced it the scores were identical, and it seemed absurd to penalize you for that).

Keep going, you've clearly learned a lot!

Looking forward to seeing what you create in the future. :)

On Mon, Oct 22, 2018 at 1:09 PM ChrisH667 notifications@github.com wrote:

Your feedback is much appreciated, Gabriel. I struggled quite a bit with Class concepts, so I was expecting a dumpster fire of a review. :) I've fixed the two errors, and now have the below result, hopefully correct this time. I uploaded a new file, Murder+Mystery+FIXED.ipynb. Lily: 0.3202063002470752 Myrtle: 0.08022675114938956 Gregg: 0.2297903530195564

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisH667/pwp-capstones/issues/8#issuecomment-431919378, or mute the thread https://github.com/notifications/unsubscribe-auth/AMRT3uNOuVYfbL8XL5sBO65weesnP3zbks5ungnXgaJpZM4XzyKg .