search

ChrisHammond / DNNTemplates

Christoc's DotNetNuke Extension Development templates for Visual Studio
http://www.christoc.com/Products/DNN-Development-Templates
Other
97 stars 38 forks source link

SPA settings issue #30

Closed ChrisHammond closed 2 years ago

ChrisHammond commented 8 years ago

Thanks for your work Chris. I recently found an issue in the SPA module template within the Settings.html file. Specifically, the JS script embedded in that page, which initializes the Quick Settings save/cancel button click events, is being wrapped in an IIFE causing the click handlers not to be wired correctly. (At least that's my diagnosis). The correction I made was to change the script in Settings.html to align with how those functions are being kicked off in View.html and Edit.html. Namely, making this function fire when the complete DOM has loaded vs. when the parser encounters the script. The group over at GitHub DNNSoftware, have done the same:

https://github.com/dnnsoftware/DNN.Templates/blob/master/src/DnnSpaModule/Settings.html

ChrisHammond commented 2 years ago

Closing as I don't know that this is still an issue