Cannot get to a level three menu item using desktop/or mobile browser

ChrisHammond / HammerFlex

Another free open source skin for DNN (DotNetNuke) using Bootstrap 3 grab the latest release from the RELEASES tab. https://github.com/ChrisHammond/HammerFlex/releases

http://www.christoc.com/Projects/HammerFlex

MIT License

30 stars 22 forks source link

Cannot get to a level three menu item using desktop/or mobile browser #20

Closed RichardHowells closed 7 years ago

RichardHowells commented 9 years ago

I find I cannot get to a level three menu item using a desktop browser. Not in a position to test with mobile browser.

Steps to repro. I started with a brand new DNN 7.4.0 install. Installed Hammerflex 0.1.09.

Add three pages Level1, Level2 (as a child of level 1), Level 3 (as a child of level 2).

Disable the pages Level1 and Level2

Navigate to the home page. A click on the Level1 menu item reveals Level2. A click on Level2 does nothing. I expected it to reveal Level3.

RichardHowells commented 9 years ago

Now tested on a mobile browser (Android 5). Same problem.

ChrisHammond commented 9 years ago

I do not have time to work on HammerFlex for a few weeks. If you come up with a fix please feel free to submit a PULL request

RichardHowells commented 9 years ago

I nearly have a pull request for you that fixes this issue.

I have a problem understanding how the build templates are intended to work. I changed the file Skins\HammerFlex\css\bootstrap.css. I assumed that the RELEASE Build process would recreate the bootstrap.min.css. It did not.

How is it intended to build the min version? I can see that the actual skin references the min version.

ChrisHammond commented 9 years ago

It won't touch min.css, I didn't build that into the templates. You'll need to make the change in both places unfortunately.

RichardHowells commented 9 years ago

Do I have to touch the bootstrap.css.map file? Is it important - if so what for?

ChrisHammond commented 9 years ago

No clue :D

RichardHowells commented 9 years ago

This SO Q http://stackoverflow.com/questions/21504611/what-are-the-map-files-used-for-in-bootstrap-3-1 suggests it's for helping debugging in some tooling that I don't use. I will ignore it.

RichardHowells commented 9 years ago

Pull request submitted. Be gentle with me - it's only the second one of these I have done.

RichardHowells commented 9 years ago

Any chance of a merge and release?

ChrisHammond commented 9 years ago

Unfortunately not for a few weeks, I'm crazy busy with paid work right now

Chris Hammond http://www.christoc.com

On Thu, Apr 2, 2015 at 1:10 PM, RichardHowells notifications@github.com wrote:

Any chance of a merge and release?

— Reply to this email directly or view it on GitHub https://github.com/ChrisHammond/HammerFlex/issues/20#issuecomment-88995592 .

RichardHowells commented 9 years ago

Given you just did a release. Any chance of merging my pull request????

efficiondave commented 9 years ago

Richard, I added your change but it's still not showing sub-sub menus. Seems there would need to be a JS change as .dropdown-menu is set to display:none.

RichardHowells commented 9 years ago

Unless I misunderstand you; I think it works for me. I changed both js and css.

capture