ChrisHirsch / kuberhealthy-storage-check

A storage check for the kuberhealthy project
Apache License 2.0
10 stars 12 forks source link

Changing CHECK_STORAGE_INIT_COMMAND_ARGS or CHECK_STORAGE_COMMAND_ARGS does not have any effect #17

Closed oeichler closed 2 years ago

oeichler commented 3 years ago

Trying to invoke the check with different command args does not work due to the following problem:

diff --git a/cmd/storage-check/storage.go b/cmd/storage-check/storage.go
index d42aefe..3f0955d 100644
--- a/cmd/storage-check/storage.go
+++ b/cmd/storage-check/storage.go
@@ -113,7 +113,7 @@ func initializeStorageConfig(jobName string, pvcName string) *batchv1.Job {

        // Make a Pod spec.
        var command = []string{defaultCheckStorageInitCommand}
-       var args = []string{"-c", defaultCheckStorageInitCommandArgs}
+       var args = []string{"-c", checkStorageInitCommandArgs}
        pvc := &corev1.PersistentVolumeClaimVolumeSource{
                ClaimName: pvcName,
        }
@@ -172,7 +172,7 @@ func checkNodeConfig(jobName string, pvcName string, node string) *batchv1.Job {

        // Make a Job spec.
        var command = []string{defaultCheckStorageCommand}
-       var args = []string{"-c", defaultCheckStorageCommandArgs}
+       var args = []string{"-c", checkStorageCommandArgs}
        pvc := &corev1.PersistentVolumeClaimVolumeSource{
                ClaimName: pvcName,
        }
github-actions[bot] commented 3 years ago

:wave: Welcome to Kuberhealthy Storage Check. Thanks for opening your first issue.

ChrisHirsch commented 3 years ago

Thank you! I'll take a look and get a PR. Would you be willing to test it?

oeichler commented 3 years ago

Yes - sure.

oeichler commented 3 years ago

Hi Chris, any progress with fixing the code? Would be great to have some public working version rather than using some private, patched image.

ChrisHirsch commented 2 years ago

Sorry for the very long delay...let me get this spun back up and I'll get this PR officially released.