Closed chaitanyagurrapu closed 10 years ago
What's the reason for the tag? GitHub automatically links to those sections, like this: https://github.com/ChrisMissal/Formo#property-binding
Is there another use for that?
Oh, I see, because there was a link added. Can you just remove the anchor and use the link from my previous comment? After that, good to go!
I read an article that seemed to encourage relative links instead of absolute ones (https://help.github.com/articles/relative-links-in-readmes), even though it talks about linking between different markdown files. My interpretation of that article was that wherever possible use relative links so they are resilient to forks and can be edited/read by stand alone markdown editors.
I can still change it and use the link you provided if you think that would be the best way...
I figured out that you weren't suggesting putting an absolute link. Updated the PR after removing the custom anchor tag and linking directly to the git hub generated anchor tag.
Ah, yeah, sorry, I could have been more clear there. Looks good, thanks again @chaitanyagurrapu!
...s when binding to a class.