search

ChrisNZL / Fauxbar

An alternative to Chrome's Omnibox.
https://chrome.google.com/webstore/detail/fauxbar/hibkhcnpkakjniplpfblaoikiggkopka
MIT License
89 stars 13 forks source link

Fauxbar Address Box matches “Error: URl malformed” text #35

Closed seanryan-seanryan closed 5 years ago

seanryan-seanryan commented 6 years ago

When typing characters in the Fauxbar Address Box, it returns hits for bookmarks marked “Error: URl malformed” (it matches on the substring “URl malformed”). So when I type “med”, it highlights all “URl malforMED”. Can you change this behaviour? PS: The “Error” bookmarks are those with embedded “%s” which are compatible with another Chrome extension that has the ability to substitute %s with address bar text provided as a search string.

Thanks for a brilliant extension!

ChrisNZL commented 6 years ago

Thanks for reporting both issues.

It seems Fauxbar's urldecode method is failing to parse the URL since %s is not a valid encoding character (eg doesn't match anything on this HTML encoding list).

I will likely investigate seeing if, in the event of it failing to decode, if returning the URL as is would work better.

ChrisNZL commented 5 years ago

Fixed in v1.8.0. Added a catch to just return the URL as is if the URI malformed error is encountered.