ChrisNZL / Fauxbar

An alternative to Chrome's Omnibox.
https://chrome.google.com/webstore/detail/fauxbar/hibkhcnpkakjniplpfblaoikiggkopka
MIT License
90 stars 13 forks source link

Firefox style search with * and ^ in the address box? #68

Open clarkwang opened 2 years ago

clarkwang commented 2 years ago

To take most advantage of Fauxbar I enabled both "Show results from history" and "Show results from bookmarks" but quite often I'd like it to search bookmarks only since there are usually too many entries in the browsing history. So can we make it behave like Firefox's address bar?

clarkwang commented 2 years ago

Found the secret is:fav in code.

ChrisNZL commented 2 years ago

Yeah, adding is:fav to the query is the only way to restrict the search to bookmarks at the moment.

Would be keen to make * and behave like Firefox as options, sure.

Definitely room for improvement within Fauxbar's Options to explain such things better.

clarkwang commented 2 years ago

Hi ChrisNZL,

The following change works fine for me. Could you help integrate it into the repo and build a new release?

diff --git a/Fauxbar/js/fauxbar-1.js b/Fauxbar/js/fauxbar-1.js
index 73115a1..7c4fc84 100755
--- a/Fauxbar/js/fauxbar-1.js
+++ b/Fauxbar/js/fauxbar-1.js
@@ -2555,7 +2555,7 @@ function getResults(noQuery) {

                    for (var w in words) {
                        if (words[w] != "") {
-                           if (words[w].toLowerCase() == 'is:fav') {
+                           if (words[w] == '*' || words[w].toLowerCase() == 'is:fav') {
                                modifiers += ' AND type = 2 ';
                            }
                            else {
ChrisNZL commented 2 years ago

Marking this issue for the upcoming 1.9 version.

If you create a pull request, I can link it properly...

But if not, your change above looks fine; I'll integrate it in due course.

(Lately, have been slowly tackling the Manifest V3 refactor, so not really keen to push a new version live until that's done. But can apply your change as I go through the list)

clarkwang commented 2 years ago

I'd not bother making a pull request. Just integrate it. We really need this feature.