Online Co-op: Players able to pick up key at same time, resulting in sync issues - Githubissues

ChrisNZL / Tallowmere2

Changelog, issue tracker, and development knowledge for Tallowmere 2.

https://tallowmere2.com

13 stars 0 forks source link

Online Co-op: Players able to pick up key at same time, resulting in sync issues #1007

Closed ChrisNZL closed 2 years ago

ChrisNZL commented 2 years ago

Manual report, version 0.3.3, feedback ID 20220311-5DXC9

been playing some online coop the past few days and found the key duplication bug mentioned in the forums: if we picked up the key at the same time both of us have one, sometimes i was unable to drop mine and couldn't attack.

picking up a new key fixes this although the key graphic remains.

reconnecting also fixes it completely

Related class: NetworkMessage_PickUpTemporaryItem

To check:

[x] Ensure server is checks all appropriate "can player pick up the key?" methods.
[x] Check if key is already being held by any player.
- Looking at my code, looks like server does not check if key is already being held by other players; only checks if the asking player is already holding something or not.

ChrisNZL commented 2 years ago

Fixed in 0.3.4.

NetworkMessage_PickUpTemporaryItem now checks for GibStruct.IsBeingHeld, and returns early if the key is being held by any player.