ChrisNZL / Tallowmere2

Changelog, issue tracker, and development knowledge for Tallowmere 2.
https://tallowmere2.com
13 stars 0 forks source link

iOS / Google Play / CloudOnce: Some achievements not incrementing? #1115

Closed ChrisNZL closed 1 year ago

ChrisNZL commented 1 year ago

Some warnings with CloudOnce, Tallowmere 2 v0.3.7

Potential issues with double calculations not quite honoring percentages properly with what's been progressed using task/achievement values stored in Account.t2 versus CloudOnce's double requirements for Game Center and Google Play:

WARNING: CloudOnce failed to increment achievement.
result.Error: Can't increment UnlockWeapon_Bow_Poison (UnlockWeapon_Bow_Poison) to 18.80%. Achievement is already at 19.00%.
task.id: UnlockWeapon_Bow_Poison
task.CurrentValue: 47
task.maxValue: 250
task.PercentageDone: 0.188
percentageDone_double (for CloudOnce): 18.7999992370605
Tallowmere2.<>c__DisplayClass3_1:<_PrepTask>b__0(CloudRequestResult`1)
CloudOnce.Internal.UnifiedAchievement:Increment(Double, Action`1)
Tallowmere2.TaskProgressManager_CloudOnce:_PrepTask(Task)
Tallowmere2.TaskProgressManager:PrepTask(Task)
Tallowmere2.TaskProgressManager:SubmitTaskProgress(Task)
Tallowmere2.Task:CommitToDiskAndSubmitTaskProgress()
Tallowmere2.Task:IncreaseProgress()
Tallowmere2.TaskProgressManager_CloudOnce:OnAccountReceivedData_SyncTaskProgressData()
Tallowmere2.Platform_CloudOnce:CloudOnce_OnCloudLoadComplete(Boolean)

Should be fine if Account.t2's Task.CurrentValue keeps increasing... Likely a recent issue with Account.t2 file not syncing properly with the Cloud Sync bug that resided in 0.3.6 for the mobile launch. I think things should be okay now, but will need to keep an eye on stuff.

Added extra logging for 0.3.7 in any case. May need to do more testing for some of the larger unlocks (like arcane bow in high rooms).

ChrisNZL commented 1 year ago

Believe this should be fixed in 0.3.7j, with Account file being synced better when receiving data from CloudOnce.