Online Co-op: Client-side number oddities

[ChrisNZL]

Steam thread: https://steamcommunity.com/app/655740/discussions/0/3493131640459500668/

0.3.7a

To investigate:

• Elite enemy healthbar stretches across screen when health is low?
• Elite enemy health takes extra hits before death?

Probably a client-side issue with how enemy's current health is calculated (while waiting for response from server) regarding recent number refactor from 0.3.7.

[ChrisNZL]

Investigating this – Not really related to Elites; but able to see it more clearly since the healthbar goes out of whack.

With various testing of receiving damage and dying, there are some weird number-jumping / out-of-sync health transactions happening at times. Likely a regression started from 0.3.7 with the new integer-checking systems.

Likely an issue with the OnlineHealthSyncer class, and calling CreatureStruct.SyncHealth.

[ChrisNZL]

Issue identified in 0.3.7a:

• The server sends "sync" messages with health values, but the client does not factor these in properly with the client's local transaction system... resulting in ever-increasingly large damage numbers, which affect healthbar numbers. Server retains the true values, but the client can display incorrect health values between sync messages.

[ChrisNZL]

Fixed in 0.3.8:

• Number transactions for adding and subtracting were not being cleared properly after being hard-set. Fixed.

Additionally:

• Player health syncing is now less jumpy. (client still receives health sync messages the same, but only updates the health after ~800ms if no health changes have occurred, and this timer resets every time the health changes, resulting in less abrupt changes, with no visible number jumps in most cases)