Refactor menu.py - Githubissues

ChrisNeedham24 / microcosm

A little 4X game written using Pyxel.

GNU General Public License v3.0

9 stars 8 forks source link

Refactor menu.py #85

Closed ChrisNeedham24 closed 1 year ago

ChrisNeedham24 commented 1 year ago

This one might be a little more complicated. To begin with, the display functionality can be extracted out, but then also divided up potentially.

jasonlwj commented 1 year ago

👀 I've already started cheeky work on my own branch for this file

ChrisNeedham24 commented 1 year ago

Refactoring as cheeky work :TrollDespair:

jasonlwj commented 1 year ago

Everything is cheeky work AlienDance

ChrisNeedham24 commented 1 year ago

There will probably be some fairly significant merge conflicts on this now due to #89. Apologies for that 😬

jasonlwj commented 1 year ago

How bad could it be Clueless

EDIT: oh god it's really bad 😬

ChrisNeedham24 commented 1 year ago

jasonlwj commented 1 year ago

I'm gonna open up a PR for now - my work is far from done but maybe the current changes can be merged in for now. Then I can continue working on a refactor part 2 (hell yeah it's happening)

ChrisNeedham24 commented 1 year ago

Sounds good, I'll have a look. I won't make that PR close this issue, hopefully your part 2 will do that 👀