ChrisNeedham24 / microcosm

A little 4X game written using Pyxel.
GNU General Public License v3.0
11 stars 8 forks source link

Add Ctrl + arrow keys to control menu #87

Closed Kurtsley closed 1 year ago

Kurtsley commented 1 year ago

Need to add an entry for the Ctrl + arrow keys to fast pan the map. Would like input on the exact wording. I was thinking either:

CTRL + ARROWS Fast scroll the map or HOLD CTRL Fast scroll the map

For some reason scroll sounds better than pan even though it doesn't make as much sense. Thoughts?

ChrisNeedham24 commented 1 year ago

I think of those options CTRL + ARROWS is better. Not sure about scroll vs pan, though. Might ask around and gather some opinions.

mushahidq commented 1 year ago

Hi! I'd like to contribute to the repo. Is this issue a good place to start?

Kurtsley commented 1 year ago

Go ahead, overlay_display.py is the file to you want to look at.

mushahidq commented 1 year ago

Thanks! Does this look good? image

ChrisNeedham24 commented 1 year ago

Looks great! We'll still need to standardise between pan and scroll, though, so at least one more change will be needed.

Kurtsley commented 1 year ago

I know of at least one more key that will needed to be added to this menu, the M key. Since it is getting crowded, either the Ctrl + arrows should be fit into one line or the menu could be extended vertically. Maybe need a separate issue for this.

ChrisNeedham24 commented 1 year ago

That's a good point, @Kurtsley. I think then maybe a better idea for this one would be to fit it onto one line, and then move the descriptions a little to the right. I've also talked with a few people about pan vs scroll, and we generally agreed that pan is a better descriptor because scrolling seems to suggest up and down only.

Fast pan does sound a bit odd, though, so how about Quickly pan the map, @mushahidq?

mushahidq commented 1 year ago

How does this look? image

ChrisNeedham24 commented 1 year ago

Looking great! Perhaps the text could all be moved over slightly so that the empty space is equal on each side, though?

mushahidq commented 1 year ago

image

ChrisNeedham24 commented 1 year ago

Looks good to me, @mushahidq!

ChrisNeedham24 commented 1 year ago

There may be some minor merge conflicts for this now due to #89. Hopefully nothing too major.