VS10 - AdditionalManifestFiles element should be in Manifest instead of Mt

ChrisPei / gyp

Automatically exported from code.google.com/p/gyp

0 stars 0 forks source link

VS10 - AdditionalManifestFiles element should be in Manifest instead of Mt #222

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

== What steps will reproduce the problem? ==
1. Process GYP file contains "VCManifestTool" entry.
2. Search "Mt" in generated VXPROJ file.

== What is the expected output? What do you see instead? ==
VXPROJ file should have "Manifest" element instead of "Mt" element.

== What version of the product are you using? On what operating system? ==
Any

== Please provide any additional information below. ==
Sample entry of VCManifestTool

{
targets: [
  {
    'msvs_settings': {
        'VCManifestTool': {
          'AdditionalManifestFiles': 'FooBar.manifest',
        },
    },
  },
],
}

Original issue reported on code.google.com by yosin@chromium.org on 29 Sep 2011 at 6:22

GoogleCodeExporter commented 9 years ago

This bug is caused by below definition:
  http://code.google.com/p/gyp/source/browse/trunk/pylib/gyp/MSVSSettings.py#485
  _manifest = _Tool('VCManifestTool', 'Mt')

It seems that it is hard to change MSBuild name(== element name) based of MSVC 
version.

Original comment by yosin@chromium.org on 29 Sep 2011 at 6:27

GoogleCodeExporter commented 9 years ago

I just run into this bug. because of this bug My views example don't show the 
tooltips because the manifest no have common-control 6.0 .
manifest file is just a nightmare.

Original comment by LianLiu...@gmail.com on 22 Oct 2011 at 3:35

GoogleCodeExporter commented 9 years ago

I ran into this bug too. Why this bug is not fixed yet?

Original comment by ningxin...@gmail.com on 13 Apr 2012 at 3:21

GoogleCodeExporter commented 9 years ago

Issue 266 has been merged into this issue.

Original comment by robertsh...@chromium.org on 11 May 2012 at 1:49

GoogleCodeExporter commented 9 years ago

Original comment by gab@chromium.org on 17 May 2012 at 3:16

GoogleCodeExporter commented 9 years ago

Commit: f635090bed695f70f98e90cb933045d2ec465f04
 Email: bradnelson@google.com@78cadc50-ecff-11dd-a971-7dbc132099af

Fixing mistake in the mapping of manifest settings from vcbuild to msbuild.

Mt should have been Manifest.
Perils of tests that recaptiulate the implementation.

BUG=http://code.google.com/p/gyp/issues/detail?id=222
TEST=None
R=scottmg@chromium.org,pkotwicz@google.com,robertshield@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10383282

git-svn-id: http://gyp.googlecode.com/svn/trunk@1391 
78cadc50-ecff-11dd-a971-7dbc132099af

M   pylib/gyp/MSVSSettings.py
M   pylib/gyp/MSVSSettings_test.py

Original comment by bugdroid1@chromium.org on 22 May 2012 at 8:05

GoogleCodeExporter commented 9 years ago

Original comment by grt@chromium.org on 28 May 2012 at 7:47

GoogleCodeExporter commented 9 years ago

Fixed? If so, can the link from 
http://www.chromium.org/developers/how-tos/build-instructions-windows to here 
be removed?

Original comment by thakis@chromium.org on 27 Aug 2012 at 9:30

GoogleCodeExporter commented 9 years ago

Yes and yes (I don't have edit access to this bug looks like; nor to the 
website).

Original comment by gab@chromium.org on 27 Aug 2012 at 9:44

GoogleCodeExporter commented 9 years ago

For past sins, I apparently do, so marking this bug as Fixed. I'll also clean 
up the page at 
http://www.chromium.org/developers/how-tos/build-instructions-windows :)

Original comment by robertsh...@chromium.org on 21 Sep 2012 at 2:10

Changed state: Fixed