search

ChrisPei / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

ninja should support 'EmbedManifest' setting. #321

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Looking at msvs_emulation.py, _GetLdManifestFlags:

# Of particular note, we do not yet support 'EmbedManifest' because
# it complicates incremental linking.

Lack of 'EmbedManifest' support makes it not possible to use ninja to produce 
an official build of Chrome Remote Desktop (since it relies on the manifest to 
be properly embedded into the binaries).

Original issue reported on code.google.com by alexeypa@chromium.org on 15 Feb 2013 at 6:30

GoogleCodeExporter commented 9 years ago 
Fixed by https://code.google.com/p/gyp/source/detail?r=1655.

Original comment by alexeypa@chromium.org on 24 Jul 2013 at 8:05