Windows Ninja generation doesn't pass through the BaseAddress flag.

ChrisPei / gyp

Automatically exported from code.google.com/p/gyp

0 stars 0 forks source link

Windows Ninja generation doesn't pass through the BaseAddress flag. #382

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

In msvs_emulation.py, GetLdFlags doesn't have an entry for BaseAddress. This 
prevents DLLs generated with the ninja build from having anything other than 
the default base address, which is bad for performance testing.

Original issue reported on code.google.com by robertsh...@chromium.org on 19 Nov 2013 at 3:44

GoogleCodeExporter commented 9 years ago

Seems to be landed as r1794.

Original comment by yukawa@chromium.org on 23 Nov 2013 at 5:24

Changed state: Fixed
Added labels: OpSys-Windows