search

ChrisPei / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Ninja generator does not support MSVS TargetPath macro. #462

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Generate a GYP file using the TargetPath macro.
2. Run gyp in Ninja mode.
3. Execute the ninja build.
4. Watch it complain about an improperly escaped '$', preceding the macro.

What is the expected output? What do you see instead?

I expect the macro to have been replaced with the path of the generated target 
in the Ninja file, and the build to proceed as usual.

Original issue reported on code.google.com by chri...@chromium.org on 6 Oct 2014 at 1:29

GoogleCodeExporter commented 9 years ago 
Fix reviewed here:

https://codereview.chromium.org/629543002/

and landed here:

https://code.google.com/p/gyp/source/detail?r=1988

Assigning to scottmg@ for verification.

Original comment by chri...@chromium.org on 6 Oct 2014 at 2:19