Generalise types of logInfo and logError

ChrisPenner / rasa

Extremely modular text editor built in Haskell

GNU General Public License v3.0

616 stars 42 forks source link

Generalise types of logInfo and logError #57

Closed jmatsushita closed 6 years ago

jmatsushita commented 6 years ago

This allows to use logInfo and logError in the BufAction monad which is quite useful to troubleshoot extensions.

PS: It would be nice to revive logger too, but I'm not sure which way to go yet. Would a bunch of Show instances on AppState do?

ChrisPenner commented 6 years ago

Looks good; might be nice to use a proper logging framework at some point in the future so that the output location is configurable, but this is a simple and effective change in the meantime 👍