search

ChrisPenner / slick

Static site generator built on Shake configured in Haskell
BSD 3-Clause "New" or "Revised" License
204 stars 24 forks source link

trivial fix for those who want to use slick with aeson 2 #24

Closed tscholak closed 2 years ago

tscholak commented 2 years ago

This is a draft PR, because I did not change the package.json or stack.yaml files. Afaik, there currently is no stack release that uses both ghc 8.10.7 and aeson 2. However, this fix may still be useful for people who use slick without stack. I publish the changes here for improved visibility.

bergmark commented 2 years ago

the latest stackage nightly has aeson 2 now.

ChrisPenner commented 2 years ago

Thanks! I'll merge for now, and would be happy to push a new version when there's a stable stack snapshot with aeson-2

Cheers!

sondr3 commented 2 years ago

LTS 19.7 contains aeson-2 now :slightly_smiling_face:

lrworth commented 1 year ago

It'd be worth a new hackage release for this.

ChrisPenner commented 1 year ago

Shipped Version 1.2.0.0 https://hackage.haskell.org/package/slick

Clindbergh commented 1 year ago

@ChrisPenner Why is this change missing in the latest stackage release (1.2.2.2)? The source code is contains the old code, see: https://www.stackage.org/haddock/lts-18.28/slick-1.1.2.2/src/Slick.Pandoc.html#loadUsingMeta

This causes the package to be broken on nix.

lrworth commented 1 year ago

Why is this change missing in the latest stackage release (1.2.2.2)?

The latest version on Hackage is 1.2.0.0. Your link goes to version 1.1.2.2.

Clindbergh commented 1 year ago

Why is this change missing in the latest stackage release (1.2.2.2)?

The latest version on Hackage is 1.2.0.0. Your link goes to version 1.1.2.2.

You are right. Thanks for the quick update and sorry for the confusion.

I noticed with the newer nixpkgs slick is updated and no longer broken, see https://github.com/NixOS/nixpkgs/commit/8e10587e#diff-db620ccbf4b3a2612bf583eadebb88f54f7ed670f5be5eaf804cbcdd51fb2db3R261053