ChrisRAoW / mautic-rss-to-email-bundle

Mautic plugin to send emails from RSS
102 stars 23 forks source link

[Feature Request] Conditional Tags #2

Closed justlevine closed 4 years ago

justlevine commented 6 years ago

Would love to see a future release include conditional tags. Something along the lines of {iffeed:tag_name == 'value'} <div> ...{feeditem...}</div> {/iffeed}. Could be similar to Mailchimp's Conditional Merge Tags, just testing the $content returned from ItemsParser.php

I'm out of the country for the next few months, but I will happily write the PR when I'm back in June (if no one beats me to it)

ChrisRAoW commented 6 years ago

Thanks for your idea. Will put it on the todo, but am really busy with client work at the moment

eugusouza commented 6 years ago

Hello @ChrisRAoW congratulations for this plugin, but the smae don't work in anyone version.

I tested in 2.12, 2.12.1, 2.13 and 2.13.1 and nothing.

Best regards.

ChrisRAoW commented 6 years ago

It was created in version 2.12. So it will certainly work. What do you experience?

eugusouza commented 6 years ago

By the way... In 2.12 it's not working.

When sending the test email it was processing forever and nothing.

When sending the e-mail to some of my team's contacts, it was processing forever and nothing.

That is, it did not work at all.

PS: I always use segment email for testing.

ChrisRAoW commented 6 years ago

Did you check the error log?

eugusouza commented 6 years ago

Yeah...

Error in line 12 Folder "Feed" file "Feed.php" $feed = new SimplePie();

I try the all possibilities and nothing.

ChrisRAoW commented 6 years ago

Can you check if your vendor folder contains a simplepie folder?

eugusouza commented 6 years ago

The "Simplepie" folder doesn't exist.

What is yout content?

ChrisRAoW commented 6 years ago

That's your problem. Did you install the plugin through composer? (following the instructions on github)?

eugusouza commented 6 years ago

Yes. Absolutely the same.

But anyway, I'm now in version 13.1.

Can you tell me if it works on her?

ChrisRAoW commented 6 years ago

Got the same issue now. Will try to fix tonight.

eugusouza commented 6 years ago

Ok. Can you inform me of the correction and update, please?

ChrisRAoW commented 6 years ago

Nevermind, it is working in 2.13.1 as it is. But after update you have to run the composer command again from the mautic root composer require raow/mautic-rss-to-email-bundle

ChrisRAoW commented 6 years ago

@eugusouza Is it workingfor you now?

eugusouza commented 6 years ago

@ChrisRAoW the same problem in Mautic 13.1.

And now, the system is shoutdown when insert your plugin.

ChrisRAoW commented 6 years ago

@eugusouza Can you find something in the log-files?

eugusouza commented 6 years ago

@ChrisRAoW I could not even see it, because when I installed it in version 13.1, it returned error 500 and I could not even open the Mautic.

In order to run, I had to delete your plugin. Only then did it work again.

eugusouza commented 6 years ago

@ChrisRAoW now it's running ok.

Any question. I use the code in Campaign Email or Segment Email.

How it works better?