search

ChrisRAoW / mautic-rss-to-email-bundle

Mautic plugin to send emails from RSS
103 stars 23 forks source link

Problem with html-encoding in feed-url #60

Closed iparker closed 2 years ago

iparker commented 2 years ago

Hello,

we have a problem with out feed-url because they contain multiple get parameter.

The url is something like https://www.url.de/api/endpoint.rss?param1=value1&order[random]&itemsPerPage=5&top_offer=1&sponsored=1

But inside the mautic editor happens some kind of html-encoding, so the url is saved as

https://www.url.de/api/endpoint.rss?param1=value1&order[random]&itemsPerPage=5&top_offer=1&sponsored=1

And this makes problems with fetching the items from the feed.

We make a simple solution: just replace & with & in the feed url.

Best regards,

Timo

ChrisRAoW commented 2 years ago

@iparker What version of mautic are you using?

iparker commented 2 years ago

We are using 4.0.1 or 4.1.1 but with the legacy email editor.

ChrisRAoW commented 2 years ago

@iparker Alright...Will try to look into it soon, currently really busy with other projects.

ChrisRAoW commented 2 years ago

@iparker This was fixed in the latest 1.6.0 release

TornMarketing commented 2 years ago

How are we handling html encoding for the broader piece?

Getting the quotes to be encoded in both html and mjml Mautic V4.0 - V4.4

<mj-raw>
      {feed url=&quot;https://www.domain.com/feeds/posts/rss/&quot;}
      {feeditems}
      <h3>{feeditem:title}
      </h3>
      <p>
        <small>{feeditem:date format=&quot;d-m-Y H:i&quot;}</small>
      </p>
      <p>{feeditem:description}
      </p>
      <p>
        <img src="{feeditem:image}"/>
      </p>
      {/feeditems}
      {/feed}
    </mj-raw>
ChrisRAoW commented 2 years ago

@TornMarketing Interesting. If you replace the """ by the correct character manually will be changed back after save?

TornMarketing commented 2 years ago

@TornMarketing Interesting. If you replace the """ by the correct character manually will be changed back after save?

Yeah cycle's back on save

Mautic implement the encode a while back to clean code (over a yr ago), has effected my style selectors

Donno how the issue hasn't come up before

ChrisRAoW commented 2 years ago

@TornMarketing Haven't experienced it so far either. Not another plugin installed recently that can cause this?

TornMarketing commented 2 years ago

@TornMarketing Haven't experienced it so far either. Not another plugin installed recently that can cause this?

Tried on a few different instances, Latest was brand new default config

ChrisRAoW commented 2 years ago

@TornMarketing Ah, then it's something I have to check. Can you give me some steps to reproduce the issue?

TornMarketing commented 2 years ago

@TornMarketing Ah, then it's something I have to check. Can you give me some steps to reproduce the issue?

Thinking on this further Wondering it's a database thing

My old mautic ticket I neglected to follow up on when I migrated from 3 to 4, effectively the same issue. https://github.com/mautic/mautic/issues/10508

-- edit -- But this issue is on quotation marks inside your tags, doesn't affect images or other mjml/HTML tags

ChrisRAoW commented 2 years ago

I'm quite busy currently, but I will try to find out if this is something I can reproduce too. Can you give me some steps nevertheless?

TornMarketing commented 2 years ago

I'm quite busy currently, but I will try to find out if this is something I can reproduce too. Can you give me some steps nevertheless?

Recreation Mjml mj-raw Copy n paste from github, update url, save, test send

Html code Same as above