ChrisRAoW / mautic-rss-to-email-bundle

Mautic plugin to send emails from RSS
102 stars 23 forks source link

Image and Categories tags not picking up value #9

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hello Chris,

I've been trying to build a customised newsletter for a client and tried all available tags to see what do they deliver when it parses my client's WordPress site. Most work well but I noticed that image and category data are not getting displayed correctly. Here's the link to the sample and here is the feed I'm using. Any thoughts?

Further, if we want to parse additional or custom tags, can we do that by changing php codes directly on the already installed plugin? I know it's not the best way to do it but theoretically would that work? If it would, what are the files we need to specifically look at?

Many thanks in advance.

ChrisRAoW commented 6 years ago

By default Wordpress doesn't include the featured images in the feed. This can be fixed with this plugin: https://wordpress.org/plugins/wp-feed-post-thumbnail/ (there are more). Install it and configure it and it should work right away.

The categories aren't implemented correctly on my end. Will try to fix this today.

If you want to have additional tags we could add them to the plugin. Do you already have some tags in mind?

ghost commented 6 years ago

We have added featured images through functions.php not through a plugin. Would that make any difference?

Tags we like to parse are custom tags specific to a project. Like Original Price, Sale Price, Offer Percentage etc, Not sure if it's fair to expect them from this. On the other hand such tags would be immensely useful for a product feed such as a Woocommerce products feed.

Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie

On Tue, 19 Jun 2018 at 13:21, ChrisRAoW notifications@github.com wrote:

By default Wordpress doesn't include the featured images in the feed. This can be fixed with this plugin: https://wordpress.org/plugins/wp-feed-post-thumbnail/ (there are more). Install it and configure it and it should work right away.

The categories aren't implemented correctly on my end. Will try to fix this today.

If you want to have additional tags we could add them to the plugin. Do you already have some tags in mind?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398379208, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-5p4cTcWPNACw_ulm7_WCvzGi-c6-6ks5t-OyxgaJpZM4UrmLd .

ChrisRAoW commented 6 years ago

That wouldn't make any difference. But the RSS should contain an media or enclosure tag containing the url to the image.

We use the SimplePie library to parse the RSS / XML file. If simplepie has a solution the parse it from the xml we can create a solution map it to the Email. Do you have an xml already containing this information?

I just release an update of the plugin which fixed parsing the categories.

ghost commented 6 years ago

Here's how images appear with the feed:

Far from a commune or coop, these planned villages are no less about cooperation and community. Read the full article here: For Active Seniors, Cohousing Offers A Cozier Alternative To Downsizing | KHN]]>

It displays the image within description area but not in where we use the tag to display the image.

I've asked my developer to have a look at the SimplePie library and make changes to his XML files to comply with SimplePie. I'll get back to you when I have an update from them.

Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie

On Tue, 19 Jun 2018 at 15:08, ChrisRAoW notifications@github.com wrote:

That wouldn't make any difference. But the RSS should contain an media or enclosure tag containing the url to the image.

We use the SimplePie library to parse the RSS / XML file. If simplepie has a solution the parse it from the xml we can create a solution map it to the Email. Do you have an xml already containing this information?

I just release an update of the plugin which fixed parsing the categories.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398411847, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-5pwoYvk21xAzpV5cownIFuTrVkPaoks5t-QXEgaJpZM4UrmLd .

ChrisRAoW commented 6 years ago

You include the image now in the description. But it should be in its own media of enclosure tag. The plugin a suggested does just that.

ghost commented 6 years ago

We tried with this, outside the Description tag but still no luck:

Any suggestions?

Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie

On Tue, 19 Jun 2018 at 20:39, ChrisRAoW notifications@github.com wrote:

You include the image now in the description. But it should be in its own media of enclosure tag. The plugin a suggested does just that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398520174, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-5pw844YcKcGd2vwL5UTkmSu9_olAjks5t-VNqgaJpZM4UrmLd .

ChrisRAoW commented 6 years ago

This isn’t going to work. You need the media or enclosure tag. http://www.rssboard.org/media-rss http://www.rssboard.org/media-rss

Chris Schrijver Eigenaar Stationsplein 4 3844 KR Harderwijk 0341 - 75 15 15 <tel:+31341751515> 06 - 13 69 07 78 <tel:+31613690778> chris@raow.nl mailto:chris@raow.nl www.raow.nl http://www.raow.nl/

Op 25 jun. 2018, om 14:59 heeft pradeepm notifications@github.com het volgende geschreven:

We tried with this, outside the Description tag but still no luck:

Any suggestions?

Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie

On Tue, 19 Jun 2018 at 20:39, ChrisRAoW notifications@github.com wrote:

You include the image now in the description. But it should be in its own media of enclosure tag. The plugin a suggested does just that.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398520174, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-5pw844YcKcGd2vwL5UTkmSu9_olAjks5t-VNqgaJpZM4UrmLd .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399942826, or mute the thread https://github.com/notifications/unsubscribe-auth/ABVFLMSWI6mUMF_Gfi5dQunFvQNOZQmZks5uAN6egaJpZM4UrmLd.

ghost commented 6 years ago

Oh I'm with you now. Will this format work or does it need more information?

-- Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie On Mon, 25 Jun 2018 at 14:00, ChrisRAoW wrote: > This isn’t going to work. You need the media or enclosure tag. > http://www.rssboard.org/media-rss > > > > > > > Chris Schrijver > Eigenaar > Stationsplein 4 > 3844 KR Harderwijk > 0341 - 75 15 15 > 06 - 13 69 07 78 > chris@raow.nl > www.raow.nl > > > Op 25 jun. 2018, om 14:59 heeft pradeepm het > volgende geschreven: > > > > We tried with this, outside the Description tag but still no luck: > > > > > > > > Any suggestions? > > -- > > Most of the important things in the world have been accomplished by > people > > who have kept on trying when there seemed to be no hope at all - Dale > > Carnegie > > > > > > On Tue, 19 Jun 2018 at 20:39, ChrisRAoW > wrote: > > > > > You include the image now in the description. But it should be in its > own > > > media of enclosure tag. The plugin a suggested does just that. > > > > > > — > > > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub > > > < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398520174 > >, > > > or mute the thread > > > < > https://github.com/notifications/unsubscribe-auth/AC-5pw844YcKcGd2vwL5UTkmSu9_olAjks5t-VNqgaJpZM4UrmLd > > > > > . > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399942826>, > or mute the thread < > https://github.com/notifications/unsubscribe-auth/ABVFLMSWI6mUMF_Gfi5dQunFvQNOZQmZks5uAN6egaJpZM4UrmLd > >. > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . >
ChrisRAoW commented 6 years ago

This should work. But like I said, the plugin I suggested does already exactly this.

Chris

Chris Schrijver Eigenaar Stationsplein 4 3844 KR Harderwijk 0341 - 75 15 15 <tel:+31341751515> 06 - 13 69 07 78 <tel:+31613690778> chris@raow.nl mailto:chris@raow.nl www.raow.nl http://www.raow.nl/

Op 25 jun. 2018, om 15:09 heeft pradeepm notifications@github.com het volgende geschreven:

Oh I'm with you now. Will this format work or does it need more information?

-- Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie On Mon, 25 Jun 2018 at 14:00, ChrisRAoW wrote: > This isn’t going to work. You need the media or enclosure tag. > http://www.rssboard.org/media-rss > > > > > > > Chris Schrijver > Eigenaar > Stationsplein 4 > 3844 KR Harderwijk > 0341 - 75 15 15 > 06 - 13 69 07 78 > chris@raow.nl > www.raow.nl > > > Op 25 jun. 2018, om 14:59 heeft pradeepm het > volgende geschreven: > > > > We tried with this, outside the Description tag but still no luck: > > > > > > > > Any suggestions? > > -- > > Most of the important things in the world have been accomplished by > people > > who have kept on trying when there seemed to be no hope at all - Dale > > Carnegie > > > > > > On Tue, 19 Jun 2018 at 20:39, ChrisRAoW > wrote: > > > > > You include the image now in the description. But it should be in its > own > > > media of enclosure tag. The plugin a suggested does just that. > > > > > > — > > > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub > > > < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398520174 > >, > > > or mute the thread > > > < > https://github.com/notifications/unsubscribe-auth/AC-5pw844YcKcGd2vwL5UTkmSu9_olAjks5t-VNqgaJpZM4UrmLd > > > > > . > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399942826>, > or mute the thread < > https://github.com/notifications/unsubscribe-auth/ABVFLMSWI6mUMF_Gfi5dQunFvQNOZQmZks5uAN6egaJpZM4UrmLd > >. > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub , or mute the thread .
ghost commented 6 years ago

Many thanks! I have two projects going on. One is standard WordPress blog which I can use that plugin. The other is a different site where we have to manually build the feed.

Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie

On Mon, 25 Jun 2018 at 14:17, ChrisRAoW notifications@github.com wrote:

This should work. But like I said, the plugin I suggested does already exactly this.

Chris

Chris Schrijver Eigenaar Stationsplein 4 3844 KR Harderwijk 0341 - 75 15 15 <tel:+31341751515> 06 - 13 69 07 78 <tel:+31613690778> chris@raow.nl mailto:chris@raow.nl www.raow.nl http://www.raow.nl/

Op 25 jun. 2018, om 15:09 heeft pradeepm notifications@github.com het volgende geschreven:

Oh I'm with you now. Will this format work or does it need more information?

-- Most of the important things in the world have been accomplished by people who have kept on trying when there seemed to be no hope at all - Dale Carnegie On Mon, 25 Jun 2018 at 14:00, ChrisRAoW wrote: > This isn’t going to work. You need the media or enclosure tag. > http://www.rssboard.org/media-rss > > > > > > > Chris Schrijver > Eigenaar > Stationsplein 4 > 3844 KR Harderwijk > 0341 - 75 15 15 > 06 - 13 69 07 78 > chris@raow.nl > www.raow.nl > > > Op 25 jun. 2018, om 14:59 heeft pradeepm het > volgende geschreven: > > > > We tried with this, outside the Description tag but still no luck: > > > > > > > > Any suggestions? > > -- > > Most of the important things in the world have been accomplished by > people > > who have kept on trying when there seemed to be no hope at all - Dale > > Carnegie > > > > > > On Tue, 19 Jun 2018 at 20:39, ChrisRAoW > wrote: > > > > > You include the image now in the description. But it should be in its > own > > > media of enclosure tag. The plugin a suggested does just that. > > > > > > — > > > You are receiving this because you authored the thread. > > > Reply to this email directly, view it on GitHub > > > < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-398520174 > >, > > > or mute the thread > > > < > https://github.com/notifications/unsubscribe-auth/AC-5pw844YcKcGd2vwL5UTkmSu9_olAjks5t-VNqgaJpZM4UrmLd > > > > > . > > > > > — > > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub < > https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399942826 , > or mute the thread < > https://github.com/notifications/unsubscribe-auth/ABVFLMSWI6mUMF_Gfi5dQunFvQNOZQmZks5uAN6egaJpZM4UrmLd > >. > > > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399943281 , > or mute the thread > < https://github.com/notifications/unsubscribe-auth/AC-5pxZICt16tUixCFn9sxYuIDj4hVe7ks5uAN71gaJpZM4UrmLd > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399945922>, or mute the thread < https://github.com/notifications/unsubscribe-auth/ABVFLIxn8pRmek1uR-qdltVueu2TJt1cks5uAOEfgaJpZM4UrmLd .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ChrisRAoW/mautic-rss-to-email-bundle/issues/9#issuecomment-399948239, or mute the thread https://github.com/notifications/unsubscribe-auth/AC-5pxYA9a6NbA_TDX_bsw1lIY4zz9paks5uAOL2gaJpZM4UrmLd .