Function and method calls became grey in Darker 2019.2?

ChrisRM / material-theme-jetbrains

JetBrains theme of Material Theme

Other

7.82k stars 450 forks source link

Function and method calls became grey in Darker 2019.2? #1289

Closed zzell closed 5 years ago

zzell commented 5 years ago

Summary

Function and method calls in Darker theme are grey instead of blue in GoLand v2019.2. Is that intended?

Expected behavior

Function and method calls should be blue as always.

Screenshot from 2019-07-26 13-42-40

Actual behavior

They are grey.

Screenshot from 2019-07-26 13-42-57

Environment

GoLand 2019.2 Build #GO-192.5728.103, built on July 23, 2019

Runtime version: 11.0.3+12-b304.10 amd64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o Linux 4.18.0-25-generic GC: ParNew, ConcurrentMarkSweep Memory: 1925M Cores: 8 Registry: run.processes.with.pty=TRUE, ide.completion.variant.limit=500, suggest.all.run.configurations.from.context=true, ide.tree.ui.experimental=false, ide.balloon.shadow.size=0 Non-Bundled Plugins: IdeaVIM, com.chrisrm.idea.MaterialThemeUI, io.protostuff.protostuff-jetbrains-plugin, BashSupport, PythonCore, org.jetbrains.settingsRepository

r00b commented 5 years ago

I have seen similar discolorations with Material Palenight in WebStorm 2019.2.

alexpolozov commented 5 years ago

Similarly for Arc Dark in PyCharm.

ryanleecode commented 5 years ago

help

Tomotoes commented 5 years ago

GoLand 2019.2

kytta commented 5 years ago

I have experienced this in WebStorm 2019.2 with Material Darker. All instance member functions turned pale orange (although they were blue before).

If you want to bring that back, you can locate the rule in Settings > Editor > Color Scheme > %LANGUAGE_NAME% > Instance member function and check the box "Inherit values from":

This will make the function the default (blue) color. I guess, that can help with other themes and other code elements (such as constructors and local variables).

EDIT: I also have rummaged through Material Darker theme XML and couldn't find any trace of these new colors being used. I believe JetBrains is to blame here, like @Tomotoes pointed out before. They probably implemented the same thing from GoLand in every IntelliJ-based IDE.

mallowigi commented 5 years ago

This happens every once and every update, the default color schemes are updated and with it, custom color schemes have their colors overridden if they do not define a value. It’s pretty annoying.

Anyway I’ve fixed that and the next update should have the colors back, but I won’t release it until at least two weeks

ryanleecode commented 5 years ago

Is there a way to get that update before you release it?