ChrisRichner / ARGUS-TV-GuideEnhancer

Electronic Program Guide Enhancer for Argus TV
https://code.google.com/p/ftr-guide-enhancer/
Apache License 2.0
1 stars 3 forks source link

sleepTimeInHours = Minutes #13

Closed Christoph21x closed 9 years ago

Christoph21x commented 9 years ago

Could you at least add a description to sleepTimeInHours that this is actually minutes, not hours? Or is it a small bug in the software? And if this should remain minutes, select maybe a different "default" in the spread config, eg 720 (=12 hours)

Greetz - Chris

ChrisRichner commented 9 years ago

As far as I can tell this behavior is unchanged since we've migrated the GuideEnhancer code base to github. The value is named correctly because it's expressing how many hours the GuideEnhancer will wait before it automatically kicks off the enriching process. The default value is 12 hours hard coded in case the config file does not provide any value at all. This value makes sure that at least all 12 hours an enriching process runs against your guide data.

enrichTimer.Interval = TimeSpan.FromHours(waitTime).TotalMilliseconds;

I looked up the code and it is handled as hours. This should work just fine.

Christoph21x commented 9 years ago

In fact, if there's no activity (like beginning/ending recordings and/or changes of schedules), the guide enricher exactly launches a log entry in Argus every 12 minutes... That's how I stumbled over it. Set it now to 720 and will be back with more information - or close it.

Greetz & thank you - Chris

ChrisRichner commented 9 years ago

Things that makes you go hmmm ,) Please let me know in case the issue still persists.

Christoph21x commented 9 years ago

Yes, sure, I'll be back with this. Currently I'm not able to enrich at all - no enrichment at all takes place.

The series names (not all checked) in the log are mostly NO RECORDING SCHEDULES at all...

2015-02-27 17:56:41 [38] DEBUG GuideEnricher.Enricher - Beginning enrichment of episodes for series Momo 2015-02-27 17:56:47 [38] ERROR GuideEnricher.Service - Error enriching System.AggregateException: Mindestens ein Fehler ist aufgetreten. ---> TvdbLib.Exceptions.TvdbInvalidXmlException: Error parsing the xml file http://thetvdb.com/api/BBB734ABE146900D/series/130161/all/de.xml

<?xml version="1.0" encoding="UTF-8" ?>

130161 ... continues with xml informations... need anything of this?
Christoph21x commented 9 years ago

Ok, I'll close this one for the time being. Enrichments aren't working here since roughly 20 hours - due to the above mentioned hour. But entering the link http://thetvdb.com/api/BBB734ABE146900D/series/130161/all/de.xml into the browser brings up: XML-Verarbeitungsfehler: nicht wohlgeformt Adresse: http://thetvdb.com/api/BBB734ABE146900D/series/130161/all/de.xml Zeile Nr. 301, Spalte 183 So - rather a TheTVDB error. I'll check the time issue (?) and be back, if it persist - or not :)

Thanks, Chris & Malyngo, for caring & your help - Chris

ChrisRichner commented 9 years ago

I'm also facing this invalid XML issue when following the provided link. It really seems to be a problem of thetvdb.com.

You're very welcome, thanks for sharing all your findings with us!

Christoph21x commented 9 years ago

Now that the failure is gone - or rather "mapped out" - I still don't understand the timing of the log entries. Config is set back to default: "12" Why then these log entries? - see attachment zwischenablage01

ChrisRichner commented 9 years ago

Good question, next question ;)

What does the GE log file looks like? What triggered the enriching process?

Malyngo commented 9 years ago

The Xml error happens because of ASCII character 31 "unit separator", btw. That one shouldn't be in a well formed Xml. (It is also not obvious, because it is an invisible character, it is in "zusammentrommeln" between "zusammen" and "trommeln".

Christoph21x commented 9 years ago

@ChrisRichner: nothing happened during this time - no other log entries than GE ones. @Malyngo: Thanks, Malyngo! Interesting - maybe a filter for certain (ranges of) char codes would make sense? But... it happened only once so far.

I close this issue, it is of none importance.

Greetz - Chris