ChrisSteinbach / mscgen

Automatically exported from code.google.com/p/mscgen
GNU General Public License v2.0
0 stars 0 forks source link

Duplicate file: bool.h #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi

I noticed that renderer/bool.h and parser/bool.h have the exact same
contents but are two separate files. Since the renderer already needs some
header files from the parser folder I figured it might as well just look
for bool.h there as well. 

~Niels

PS: The autotools branch looks good, I will give it a spin as soon as I can
get my SVN tools working.

Original issue reported on code.google.com by NThykier@gmail.com on 28 Jun 2009 at 10:00

GoogleCodeExporter commented 9 years ago
I wonder if I should just fold the renderer and parser together?  This would 
simplify
the build and licensing.

Originally I made the parser distinct so it could be used in something else 
under
LGPL, but I'm not sure that still exists or anyone else uses the parser.  So 
throwing
it together under a single GPLv2 licence might simplify this a lot?

Original comment by Michael....@gmail.com on 29 Jun 2009 at 8:29

GoogleCodeExporter commented 9 years ago
Mmm... As far as I can tell, it does not make a lot of difference license-wise 
in
terms of distributing your program. I merely have to add a short paragraph about
"parser/*" is under LGPL-2.1.

Also the build is already configured correctly: if you remove 
src/renderer/bool.h, it
still builds successfully.

That being said; if you feel it makes everything simpler, then you should merge 
the
folders and change the license. 

~Niels

Original comment by NThykier@gmail.com on 10 Jul 2009 at 12:37

GoogleCodeExporter commented 9 years ago
This issue was closed by r43.

Original comment by Michael....@gmail.com on 11 Jul 2009 at 1:22