ChrisTheCoolHut / Firmware_Slap

Discovering vulnerabilities in firmware through concolic analysis and function clustering.
GNU General Public License v3.0
470 stars 79 forks source link

subprocess.call with PIPE #13

Open madushan1000 opened 5 years ago

madushan1000 commented 5 years ago

Looks like you're using subprocess.call with std in/out reirected to pipes to run the ghidra headless in ghidra_handler.py. This will block the child process from completing if the pipe fills up(check out the warning here tmprawd8d3e/). Faced the issue myself. Please consider replacing this with either subprocess.Popen or redirecting the std in/out to subprocess.DEVNULL