Parametrize importing r2/ghidra handlers

ChrisTheCoolHut / Firmware_Slap

Discovering vulnerabilities in firmware through concolic analysis and function clustering.

GNU General Public License v3.0

468 stars 79 forks source link

Parametrize importing r2/ghidra handlers #29

Closed mmiszczyk closed 4 years ago

mmiszczyk commented 4 years ago

Seems that #17 was caused by function_handler and ghidra_handler being imported unconditionally, so that you needed both radare2 and ghidra even if you only used one of them (specifically: function_handler did import r2pipe, which you won't have if you don't install radare). I put the import behind a command-line switch, so that we won't be looking for function_handler when we don't want to, and fwslap will stop screaming at us about missing rpipe module.

ChrisTheCoolHut commented 4 years ago

Looks good, thanks for the PR!