Adding VM Dependencies option

[sevu11]

Pull Request

Title

Added VM Dependencies option

Type of Change

• [x] New feature
• [ ] Bug fix
• [ ] Documentation Update
• [ ] Refactoring
• [ ] Hotfix
• [ ] Security patch
• [ ] UI/UX improvement

Description

Added a option to install virtmanager.

Testing

Tested using Distrobox. No issues identified.

Impact

Issue related to PR

Additional Information

Script will install the required virtmanger and packages. Enable services and adding user to libvirt usergroup.

Checklist

• [x] My code adheres to the coding and style guidelines of the project.
• [x] I have performed a self-review of my own code.
• [x] I have commented my code, particularly in hard-to-understand areas.
• [ ] I have made corresponding changes to the documentation.
• [ ] My changes generate no errors/warnings/merge conflicts.

[adamperkowski]

Well, I was thinking more like

enable_services(){
    read -p "What services do you want to enable? ([S]ervice/[s]ocket/[a]ll/[n]one): " answer
    case $answer in
        S)
            printf "${YELLOW}Enabling LibVirt Service${RC}\n"
            ${ESCALATION_TOOL} systemctl enable --now libvirtd.service
            ${ESCALATION_TOOL} systemctl enable --now virtlogd
            ;;
        s)
            printf "${YELLOW}Enabling LibVirt Socket${RC}\n"
            ${ESCALATION_TOOL} systemctl enable --now libvirtd.socket
            ${ESCALATION_TOOL} systemctl enable --now virtlogd
            ;;
        a|A)
            printf "${YELLOW}Enabling both LibVirt Service and Socket${RC}\n"
            ${ESCALATION_TOOL} systemctl enable --now libvirtd.service
            ${ESCALATION_TOOL} systemctl enable --now libvirtd.socket
            ${ESCALATION_TOOL} systemctl enable --now virtlogd
            ;;
        n|N)
            printf "${YELLOW}Skipping Virt Services enablement${RC}\n"
            ;;
        *)
            printf "${RED}Invalid input.${RC}\n"
            enable_services
            ;;
    esac
}

But this works as well i guess.

EDIT: Sorry, didn't see the last commit. That works.

[nnyyxxxx]

@adamperkowski Partial upgrades are NOT supported by Arch Linux.

[adamperkowski]

@nnyyxxxx You're right. Sorry didn't think. Props for catppuccin btw

[sevu11]

I just want to take a moment to thank you @nnyyxxxx for the back and forth.
And of course, your input too @adamperkowski.

[nnyyxxxx]

@sevu11 You need to be using the provided material out of the common-script, likewise don't leave any stray package managers in the script instead use packager provided in common-script.

[nnyyxxxx]

@sevu11 When finished mark the existing reviews as resolved so we know what is done and what's not.

[sevu11]

@sevu11 When finished mark the existing reviews as resolved so we know what is done and what's not.

Will do.

[sevu11]

I will close the PR and rework it the updates merged today. I will bookmark the page for all good comments when I get around to add this PR again.