ChrisTitusTech / linutil

Chris Titus Tech's Linux Toolbox - Linutil is a distro-agnostic toolbox designed to simplify everyday Linux tasks.
https://christitus.com
MIT License
2.85k stars 227 forks source link

Revert #913 "feat: Mouse scroll" #942

Closed nnyyxxxx closed 1 week ago

nnyyxxxx commented 2 weeks ago

Reverts ChrisTitusTech/linutil#913

@ChrisTitusTech this feature lags the tui and increases cpu usage by a crazy amount, i think this should be reverted. debug: ( much worse ) image release: ( a little better but still noticeable) image

@ChrisTitusTech take a look at #936 for more information regarding the bugs that came with the merge of #913

closes #938 closes #937 closes #946 resolves #936 resolves #941 resolves #939

after merging this i think a new prerelease should be made IF this feature was included in the latest one.

Also to bake this up even more, I think tui's shouldn't have mouse interaction in the first place and I think you can agree with me on that one, BECAUSE It's ran in the terminal (1) It's too resource intensive to provide support for it (2), please consider merging this.

@ChrisTitusTech very important !! check out #946 it provides a major improvement towards this feature that includes more mouse interaction as seen in the video provided.

If you're not willing to merge this, take a look at :

938

937

946

They both provide QOL improvements towards this feature.

If you still want to keep this feature inside of Linutil then this will have to be heavily optimized and I don't think It's possible.

jeevithakannan2 commented 2 weeks ago

Running a debug will have more CPU usage add a SS of running the pre-release

nnyyxxxx commented 2 weeks ago

only a 3% difference, and the performance is about the same

image

jeevithakannan2 commented 2 weeks ago

Please check with previous a old release before implementation of mouse scroll. I don't see any difference in CPU usage before and after https://github.com/ChrisTitusTech/linutil/pull/913

image image

nnyyxxxx commented 2 weeks ago

i already have