Closed wjcroft closed 10 years ago
i mergerd your pull request, did a build and updated the resulting binary.
thank you very much for your great updates !
best regards, chris
2014-10-27 3:27 GMT+01:00 William J Croft notifications@github.com:
Chris, hi.
Here are the mods so far. Seems to test out well. Apologies for the goof of including the Setup exe accidently in my commits; I backed that out.
Best regards,
William
You can merge this Pull Request by running
git pull https://github.com/wjcroft/BrainBay master
Or view, comment on, or merge it at:
https://github.com/ChrisVeigl/BrainBay/pull/8 Commit Summary
- New OpenBCI packet format, both 8 and 16 channels.
- Oscilloscope mod for huge output range EEG devices.
- Roll the Spectrogram window rather than completely clearing it.
- Include the Setup_BrainBay.exe file in the Push.
- Remove the Setup_BrainBay.exe, it's 17MB !
File Changes
- M src/base.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-0 (6)
- M src/brainBay.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-1 (3)
- M src/brainBay.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-2 (2)
- M src/brainbay.rc https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-3 (13)
- M src/ob_eeg.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-4 (220)
- M src/ob_fft.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-5 (19)
- M src/ob_osci.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-6 (20)
- M src/resource.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-7 (4)
Patch Links:
- https://github.com/ChrisVeigl/BrainBay/pull/8.patch
- https://github.com/ChrisVeigl/BrainBay/pull/8.diff
— Reply to this email directly or view it on GitHub https://github.com/ChrisVeigl/BrainBay/pull/8.
Chris, thanks!
On Tue, Oct 28, 2014 at 8:25 AM, Chris Veigl notifications@github.com wrote:
i mergerd your pull request, did a build and updated the resulting binary.
thank you very much for your great updates !
best regards, chris
2014-10-27 3:27 GMT+01:00 William J Croft notifications@github.com:
Chris, hi.
Here are the mods so far. Seems to test out well. Apologies for the goof of including the Setup exe accidently in my commits; I backed that out.
Best regards,
William
You can merge this Pull Request by running
git pull https://github.com/wjcroft/BrainBay master
Or view, comment on, or merge it at:
https://github.com/ChrisVeigl/BrainBay/pull/8 Commit Summary
- New OpenBCI packet format, both 8 and 16 channels.
- Oscilloscope mod for huge output range EEG devices.
- Roll the Spectrogram window rather than completely clearing it.
- Include the Setup_BrainBay.exe file in the Push.
- Remove the Setup_BrainBay.exe, it's 17MB !
File Changes
- M src/base.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-0 (6)
- M src/brainBay.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-1 (3)
- M src/brainBay.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-2 (2)
- M src/brainbay.rc https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-3 (13)
- M src/ob_eeg.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-4 (220)
- M src/ob_fft.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-5 (19)
- M src/ob_osci.cpp https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-6 (20)
- M src/resource.h https://github.com/ChrisVeigl/BrainBay/pull/8/files#diff-7 (4)
Patch Links:
- https://github.com/ChrisVeigl/BrainBay/pull/8.patch
- https://github.com/ChrisVeigl/BrainBay/pull/8.diff
Reply to this email directly or view it on GitHub https://github.com/ChrisVeigl/BrainBay/pull/8.
Reply to this email directly or view it on GitHub https://github.com/ChrisVeigl/BrainBay/pull/8#issuecomment-60773823.
Chris, hi.
Here are the mods so far. Seems to test out well. Apologies for the goof of including the Setup exe accidently in my commits; I backed that out.
Best regards,
William