search

ChrisViral / RealChute

Realistic parachutes for KSP
47 stars 38 forks source link

Stopping the timewarp upon deployment #10

Closed Ippo343 closed 10 years ago

Ippo343 commented 10 years ago

The long deployment is awesome to avoid G spikes: however, the deployment seems to happen in real time discarding the timewarp time step. I suggest to stop the timewarp when the parachute deploys, for added safety.

ChrisViral commented 10 years ago

That might make sense, but that method is most definitely not the right place to drop this. LowDeploy() and Deploy() in Parachute.cs should be those targetted by this.

But first off I'll test to see if that is true, and try to make it work through timewarp, I'd rather not stop timewarp.

Ippo343 commented 10 years ago

Ops, I misunderstood your code then. Sorry :/ I'll just close the PR then. Thanks!

ChrisViral commented 10 years ago

No worries, ActivateRC() is just what's called when the part is staged, so timewarp would've stopped at staging :P No harm done, I'll simply look into it, I think it's related to me using System.Diagnostics.StopWatch