ChrisViral / RealChute

Realistic parachutes for KSP
47 stars 38 forks source link

Parachute staging icon not displayed by default if part contains both RealChuteModule and ModuleDockingNode #58

Closed sumghai closed 8 years ago

sumghai commented 8 years ago

Noticed this while working on an update for SDHI SMS.

If a part (such as my parachute-equipped docking ports) contains both RealChuteModule and ModuleDockingNode, the parachute staging icon is not displayed by default.

Reproduction Steps

Desired fix

Any part containing a RealChuteModule should always show its staging icon, regardless of any other PartModule.

Configuration

Windows 10 Pro 64 bit KSP 1.0.5 32 bit, build 01028 (fresh installation) AnimatedDecouplers v1.2.2-beta.1 (experimental release to test bugfixes) FASA 4.50 (latest release, launch clamps only) Hyperedit v1.4.2 (latest release) KSPX v0.2.9 (latest release) ModuleManager v2.6.13 (latest release) RealChute v1.2.3.6 (latest release) RLA Stockalike v13.3 (latest release) SDHI SMS 3.0.1 (latest release) Time Control v13.2+? (experimental release by westamastaflash in Xaiier's absence)

Log file

output_log.txt

Additional notes

You (or Chris rather) need to make RealChute aware of the stage toggling functionality. You need to override the stage toggle enabled methods and perhaps some other bits. Note that each module independently interacts with the stage toggling backend, and as long as >= 1 module has staging enabled,the icon will show up and the part will stage.

NathanKell commented 8 years ago

See http://bugs.kerbalspaceprogram.com/issues/5689 to which both of you should have access. Note my comment midway down with updated information.

ChrisViral commented 8 years ago

I'll look into it shortly. Sorry for the delay, it's been kinda hectic during the holidays here, heh.

ChrisViral commented 8 years ago

@sumghai Try using this dll, I think that should fix the issue.

sumghai commented 8 years ago

I'll test it tonight and report back - thanks!

sumghai commented 8 years ago

Fix works beautifully - adding an SDHI ParaDock into the VAB/SPH build area automatically adds the parachute icon to the staging list as desired.

Regression testing of parachute via action groups / staging button OK :)

ChrisViral commented 8 years ago

Good, closing then :)