search

ChrisWren / grunt-link-checker

Run node-simple-crawler to discover broken links on your website
MIT License
33 stars 9 forks source link

Switch to chalk for coloring and add time-grunt/load-grunt-tasks #13

Closed XhmikosR closed 9 years ago

XhmikosR commented 9 years ago

@ChrisWren: I hope this helps see #12. Sorry for not splitting up the patches, but let me know if you want me to change anything.

Note, that I added localhost and 9001 as the default if they are not set.

Two things I've noticed so far after switching to node.js 0.10.38 to make this work:

  1. Isn't grunt-release unused?
  2. The instructions should mention grunt-contrib-connect in the examples for localhost.

EDIT: Hmm, Travis doesn't seem to be enabled for PRs... You can check https://travis-ci.org/XhmikosR/grunt-link-checker/builds/57308777 in the meantime.

XhmikosR commented 9 years ago

@ChrisWren: I can try splitting the patches if it helps speeding up the review process.

ChrisWren commented 9 years ago

That would help to split the patches. Not sure about all the JSHint/style changes, I would prefer bug fixes and feature additions.

XhmikosR commented 9 years ago

Well, it's cleanup anyway. I'll try to split some stuff. On Apr 11, 2015 8:18 PM, "Chris Wren" notifications@github.com wrote:

That would help to split the patches. Not sure about all the JSHint/style changes, I would prefer bug fixes and feature additions.

— Reply to this email directly or view it on GitHub https://github.com/ChrisWren/grunt-link-checker/pull/13#issuecomment-91883773 .

XhmikosR commented 9 years ago

@ChrisWren: please merge the other PRs and I'll rebase and rename this one afterwards.

XhmikosR commented 9 years ago

Updated.